search

astropy / astropy-APEs

A repository storing the Astropy Proposals for Enhancement.
Other
35 stars 37 forks source link

MNT: Replace master with main #67

Closed pllim closed 2 years ago

pllim commented 3 years ago

This PR attempts to replace all mention of master to main in this repository. This should be reviewed and merged right after the maintainer has renamed the default branch.

This is an automated update made by the batchpr tool :robot: - feel free to close if it doesn't look good! You can report issues to @pllim.

This is part of #66

bsipocz commented 3 years ago

I'm not sure if this falls under the just-done "update" clause.

wouldn't this be on the level of typos? We had those fixed before without doing the update cycle and a round of approval. Basically there is no situation where these updates should be rejected...

hamogu commented 2 years ago

It seems that all the changes have been made (looking into the current main on the GH web interface). Is there a particular reason this PR is still open?

pllim commented 2 years ago

@eteq requested changes, so he should re-review.

eteq commented 2 years ago

To clarify the pause point here: It's not clear there's a consensus since I gave 3 options, and no one really voiced a preference for one over the others (except I think maybe https://github.com/astropy/astropy-APEs/pull/67#issuecomment-796041857 was suggesting option 3? A bit ambiguous but it's my best guess right now).

That said, I agree this shouldn't drag on forever because of that. And particularly since the authorship "credit" should belong to @pllim, who has not voiced a strong preference for 1, I'm going to go ahead and merge (essentially my option 3)

pllim commented 2 years ago

Thanks!