search

astropy / astropy-APEs

A repository storing the Astropy Proposals for Enhancement.
Other
35 stars 37 forks source link

Broken link in APE0 #88

Closed weaverba137 closed 10 months ago

weaverba137 commented 1 year ago

There are many links to "Voting Members", with the form

`Voting Members <votingmembers>`_

but the file votingmembers doesn't exist. Has this been moved elsewhere?

weaverba137 commented 1 year ago

Hmm, actually, this may be an issue with how GitHub renders APE0. The raw RST file may actually be correct, but GitHub is interpreting that link as https://github.com/astropy/astropy-APEs/blob/main/votingmembers.

pllim commented 10 months ago

We could hardcode the URL but does that constitute a formal update to APE? 🤔

weaverba137 commented 10 months ago

Good question. Seems like this could be classified as a typo to me.

pllim commented 10 months ago

Are you interested to submit a PR since you found the problem? Then you will be credited for the fix as well. Thanks!

weaverba137 commented 10 months ago

Sure, I'll get one in soon.

weaverba137 commented 10 months ago

I'm moving forward on the assumption that all links of the form

`Voting Members <votingmembers>`_

are meant to link to the internal section called "The Voting Members", rather than the list of actual voting members.

pllim commented 10 months ago

Yes, I was thinking of https://github.com/astropy/astropy-APEs/blob/main/APE0.rst#the-voting-members