Closed pllim closed 2 years ago
One could also turn all unhandled warnings into exceptions for pytest
in setup.cfg
but that is out of scope here.
Merging #168 (c3f26c8) into main (c6489b7) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head c3f26c8 differs from pull request most recent head 4f3d61e. Consider uploading reports for the commit 4f3d61e to get more accurate results
@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 6 6
Lines 498 498
=======================================
Hits 439 439
Misses 59 59
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4f7bbd7...4f3d61e. Read the comment docs.
I think failures are addressed in #166
I think failures are addressed in #166
Merged that. Would you please rebase this PR to check that the tests pass?
I rebased but I don't understand why Azure won't kick off.
This check was skipped
No pipeline branch filters matched the modified branch.
I don't understand either. Do you recall, were all of the tests except for the Python 3.6 ones passing? If so, then I'm happy to merge.
Yes, I think so. Well, the linux wheel also failed but I think that is because of Python 3.6 as well.
https://dev.azure.com/astropy-project/astropy-healpix/_build/results?buildId=3568&view=results
p.s. Maybe should just ditch Azure and use Actions.
p.s. Maybe should just ditch Azure and use Actions.
The latest package template does that. Would be good to just update from the template.
Re: template -- Depends. I see that someone set up wheels stuff on your Azure pipeline. So you can start with template but that might not be enough.
This pull request is to remove soon to be deprecated code; also see astropy/astropy#12633 . Also stop using
distutils
and officially set minversion forastropy
.