astropy / astropy-healpix

BSD-licensed HEALPix for Astropy - maintained by @astrofrog and @lpsinger
https://astropy-healpix.readthedocs.io
BSD 3-Clause "New" or "Revised" License
52 stars 22 forks source link

Move cibuildwheel setup to pyproject.toml #176

Closed lpsinger closed 2 years ago

lpsinger commented 2 years ago

Should also fix this error:

The workflow is not valid. .github/workflows/publish.yml (Line: 13, Col: 5): Unexpected value 'env'
lpsinger commented 2 years ago

@pllim, I have the publish workflow set only to run on the main branch. Is it OK if I self-merge this and attempt to fix it on main?

codecov[bot] commented 2 years ago

Codecov Report

Merging #176 (38ceb95) into main (0223027) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #176   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files           6        6           
  Lines         503      503           
=======================================
  Hits          444      444           
  Misses         59       59           

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

pllim commented 2 years ago

I'll let you merge since I am not sure if you want to address the pypy build here or not.

lpsinger commented 2 years ago

I'll let you merge since I am not sure if you want to address the pypy build here or not.

I'll work out the pyproject.toml for that by trail and error on main.

(I don't want to enable the publish workflow for PRs, because the publish workflow uses the CI secrets.)

pllim commented 2 years ago

I don't watch this repo, so please ping me if you need help. Thanks for cleaning up the repo and good luck!