astropy / astropy-tutorials

Tutorials for the Astropy Project
BSD 3-Clause "New" or "Revised" License
288 stars 171 forks source link

Spectroscopic Data Reduction: trace, extract, calibrate & data #511

Closed keflavich closed 1 year ago

keflavich commented 2 years ago

Tutorial 3 following #508, #510

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

adrn commented 2 years ago

I fixed the issues with the color-excess tutorial (causing your builds to fail), so if you rebase this and your other PRs (sorry...) the CI should start working again. Sorry for the headache!

eblur commented 2 years ago

Overall looks good. My only ask is to make the notebook titles in this series more clear (Part 1, 2, 3 etc with sub-titles defining the end goal of each notebook).

keflavich commented 1 year ago

I've addressed @eblur's comments and applied some other changes that were needed (header, import location, etc)