search

astropy / astropy-tutorials

Tutorials for the Astropy Project
BSD 3-Clause "New" or "Revised" License
291 stars 176 forks source link

Only run modified notebooks in PRs, with an optional label override #523

Closed adrn closed 2 years ago

adrn commented 2 years ago

Refreshing some of the CI config files so that, by default, PR builds only run notebooks that have been modified.

Note: This currently contains a test commit that modifies two notebooks, as a test of the new github actions workflow. That commit should be removed before merging, if this works!

Fixes #519

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

adrn commented 2 years ago

Oo it worked!

adrn commented 2 years ago

And it looks like the label worked as well! Changing this PR title - I think this can be merged (once I remove the test commit).

adrn commented 2 years ago

Now it works even if there are no modified tutorials - I think this is ready to merge!

adrn commented 2 years ago

Only thing I might want to add is having an artifact of the build HTML uploaded to assist with reviews; but we can handle that later.

Yea, that would be awesome to have! I'll look into some options for solutions there.