search

astropy / astropy-tutorials

Tutorials for the Astropy Project
BSD 3-Clause "New" or "Revised" License
288 stars 170 forks source link

Incorrect derivatives in User-Defined-Model tutorial #562

Closed EdBehn closed 1 year ago

EdBehn commented 2 years ago

I believe that I have have found a mathematical error in the User-Defined-Model tutorial (Full custom model section).

The derivatives should be

d_a = np.sin(b*x+c)

and

d_c = a*np.cos(b*x+c)

kelle commented 1 year ago

@rkiman , could you take a look at this?

rkiman commented 1 year ago

@kelle I fixed this last year. The issue can be closed.