astropy / astropy-tutorials

Tutorials for the Astropy Project
BSD 3-Clause "New" or "Revised" License
288 stars 170 forks source link

fix use of weights in fitting tutorial #571

Closed keatonb closed 1 year ago

keatonb commented 1 year ago

I changed all instances of weights = 1.0/error**2 to weights = 1.0/error to address #570.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

rkiman commented 1 year ago

Thank you for catching this! I would just modify your note "Note that the fitting routine takes weights as 1/error and squares them for you, which is different from the definition of weights used on the linked pages." to: Note that the fitting routine takes weights as 1/error and squares them for you, as indicated in the description of the function (and add the link, even though it is indicated in other parts of the tutorial).

keatonb commented 1 year ago

I made the change you suggested @rkiman. Cheers!

adrn commented 1 year ago

Thanks @keatonb and @rkiman !