Closed keatonb closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thank you for catching this! I would just modify your note "Note that the fitting routine takes weights as 1/error and squares them for you, which is different from the definition of weights used on the linked pages." to: Note that the fitting routine takes weights as 1/error and squares them for you, as indicated in the description of the function (and add the link, even though it is indicated in other parts of the tutorial).
I made the change you suggested @rkiman. Cheers!
Thanks @keatonb and @rkiman !
I changed all instances of
weights = 1.0/error**2
toweights = 1.0/error
to address #570.