search

astropy / astropy-workshop

Materials for Astropy Workshops
BSD 3-Clause "New" or "Revised" License
102 stars 66 forks source link

Mention lightkurve in OOP intro #221

Closed bmorris3 closed 1 year ago

bmorris3 commented 1 year ago

When I teach the OOP tutorial, I always mention that the LightCurve object created in the notebook is only meant for pedagogical purposes. I suggest that if you want to do real research with light curves, you would benefit greatly from using the lightkurve package.

In this PR, I put that commentary into text in the notebook.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

bmorris3 commented 1 year ago

(Also, happy second birthday to this notebook, introduced in https://github.com/astropy/astropy-workshop/pull/163 🎉 🍰)

bmorris3 commented 1 year ago

Hi @nstarman – is it possible astropy/astropy#12136 broke the tests in these notebooks? I'm getting build errors like this.

nstarman commented 1 year ago

The following should work.

from astropy.cosmology import parameters

parameters.available

While not deprecated, the parameters module is mostly legacy. For a one-liner use

astropy.cosmology.realizations.available
bmorris3 commented 1 year ago

Thanks @nstarman, all fixed!