astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8

http://astroquery.readthedocs.org/en/latest/

BSD 3-Clause "New" or "Revised" License

703 stars 396 forks source link

Change HTTP user-agent when running CI #1281

Closed keflavich closed 5 years ago

keflavich commented 5 years ago

To help archives separate out user & testing statistics, we can change the HTTP user agent when running from CI. This should be pretty easy....

vaishnav97 commented 5 years ago

@keflavich Which CI are you talking about here - Travis or CircleCI? I have heard of these two only. If you are talking about some other CI, then please tell me so that I can learn and start solving this issue.

keflavich commented 5 years ago

Both

kakirastern commented 5 years ago

Hi @keflavich! Can I work on this issue?

bsipocz commented 5 years ago

Feel free to!

kakirastern commented 5 years ago

I would like to prepare for GSoC 2019 and this seems like something I should work on in order to learn about CI testing as applied to astroquery.

kakirastern commented 5 years ago

@bsipocz Yup, cool! I will start work on it and open a PR to follow up soon.

kakirastern commented 5 years ago

Just wanted to check: I suppose I will need to change both https://github.com/astropy/astroquery/blob/master/.travis.yml and https://github.com/astropy/astroquery/blob/master/appveyor.yml?

kakirastern commented 5 years ago

I noticed the headers for the user-agent are set in https://github.com/astropy/astroquery/blob/master/astroquery/query.py#L148 and https://github.com/astropy/astroquery/blob/master/astroquery/utils/commons.py#L81...

kakirastern commented 5 years ago

PR #1394 opened to deal with this issue. Ready for a review...

bsipocz commented 5 years ago

1307 has addressed this.