jplhorizons remote tests fail

[migueldvb]

The remote tests have been failing for a few days. It seems related with the new ObsSub lon and lat headers, and maybe others too, that where introduced for observer tables recently and cannot be found. I've been in contact with JPL people and will try to figure out what happened.

[bsipocz]

I suppose we better go ahead with the PR. Please get back to this issue if/when there is any conclusion from talking with the JPL folks.

E.g. the new name output looks a bit weird, will that be the case from now on that named asteroids (and when one queries using the name only) refers back to the temporary designations?

Also, I would keep this issue open even after merging the PR as there are two new failures:

======================================================= FAILURES =======================================================
______________________________________ TestHorizonsClass.test_elements_query_raw _______________________________________

self = <astroquery.jplhorizons.tests.test_jplhorizons_remote.TestHorizonsClass object at 0x117bdd8b0>

    def test_elements_query_raw(self):
        res = jplhorizons.Horizons(id='Ceres', location='500@10',
                                   epochs=2451544.5).elements(
                                       get_raw_response=True)

>       assert len(res) >= 7400
E       AssertionError: assert 6876 >= 7400
E        +  where 6876 = len('*******************************************************************************\nJPL/HORIZONS                  1 Cere...\nELEM_LABELS = YES\nOBJ_DATA = YES\nREF_SYSTEM = J2000\nREF_PLANE = ECLIPTIC\nTP_TYPE = ABSOLUTE\nTLIST = 2451544.5\n')

astroquery/jplhorizons/tests/test_jplhorizons_remote.py:225: AssertionError
_______________________________________ TestHorizonsClass.test_vectors_query_raw _______________________________________

self = <astroquery.jplhorizons.tests.test_jplhorizons_remote.TestHorizonsClass object at 0x1197b3610>

    def test_vectors_query_raw(self):
        res = jplhorizons.Horizons(id='Ceres', location='500@10',
                                   epochs=2451544.5).vectors(
                                       get_raw_response=True)

>       assert len(res) >= 6900
E       assert 6617 >= 6900
E        +  where 6617 = len('*******************************************************************************\nJPL/HORIZONS                  1 Cere...M = J2000\nTP_TYPE = ABSOLUTE\nLABELS = YES\nVECT_CORR = "NONE"\nVEC_DELTA_T = NO\nOBJ_DATA = YES\nTLIST = 2451544.5\n')

astroquery/jplhorizons/tests/test_jplhorizons_remote.py:257: AssertionError
=============================================== short test summary info ================================================
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_elements_query_raw - Assertio...
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_vectors_query_raw - assert 66...
======================================= 2 failed, 31 passed, 1 skipped in 17.38s =======================================

[bsipocz]

The number of failing remote tests is growing, currently I see 4 of them.

==================================================================================================== short test summary info ====================================================================================================
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_ephemerides_query - AssertionError: 
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_elements_query_raw - AssertionError: assert 6866 >= 7400
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_vectors_query_raw - assert 6607 >= 6900
FAILED astroquery/jplhorizons/tests/test_jplhorizons_remote.py::TestHorizonsClass::test_vectors_aberrations - AssertionError: 
=========================================================================================== 4 failed, 30 passed, 1 skipped in 20.01s ============================================================================================

[bsipocz]

All jplhorizons remote tests pass, there are some minor numerical failures with the narrative docs, fix for those will come in a PR soon.