astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
695 stars 397 forks source link

Use keyword only arguments #1746

Closed bsipocz closed 1 year ago

bsipocz commented 4 years ago

Many functionalities in astroquery have numerous arguments. Many of those are optional kwarg atm, and I propose to switch to to be kwarg only. I think that would help

We've seen several cases in the past where adding new kwargs ended in awkwardness as they needed to be added to the last position to keep the API backwards compatible for position arg usage.

bsipocz commented 2 years ago

OK, so a lot of time has passed, and we moved a significant fraction of the modules to use keyword-only arguments. I would propose to try to make this change for all the modules for the next release.

bsipocz commented 1 year ago

@ceb8 @keflavich - It would be nice to go through this list for the next tagged release. Technically the changes are trivial, we only need to be careful to also change the tests and docs.

bsipocz commented 1 year ago

This is now almost fully done, the only modules remaining are having their own issues, and tracked separately, or are already deprecated for removal.

Enormous thanks to @nkphysics!