astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
703 stars 396 forks source link

Rename query_xyz_tap and query() methods to query_tap #2363

Open bsipocz opened 2 years ago

bsipocz commented 2 years ago

As we discussed in https://github.com/astropy/astroquery/pull/2122#discussion_r849801179, it would make sense to rename the module specific tap methods to be a generic query_tap, to simplify the API.

With the exception of HSA (which hasn't yet been released), this has to be done with proper deprecation. I milestone it to 0.4.7, so we'll avoid the need to deprecate for HSA (and well, 0.4.7 will have a ton of cleanup work, this would fit nicely in that logic).

Affected modules:

astroquery/esa/iso/core.py:    def query_ida_tap(self, query, *, output_file=None,
astroquery/esa/hubble/core.py:    def query_hst_tap(self, query, async_job=False, output_file=None,
astroquery/esa/xmm_newton/core.py:    def query_xsa_tap(self, query, *, output_file=None,
astroquery/esa/hsa/core.py:    def query_hsa_tap(self, query, *, output_file=None,

cc @jespinosaar

jespinosaar commented 1 year ago

eHST module has been modified in PR #2597

bsipocz commented 1 year ago

There are also a few query() or query_async() methods, that are in fact a TAP query. So ideally those could also be renamed. (There are also a few that are not direct TAP queries, those may remain, (example in the alma module))

cc @keflavich