search

astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
706 stars 399 forks source link

Download file with a directory specified by local_path parameter #3016

Closed snbianco closed 5 months ago

snbianco commented 5 months ago

Fixes #2501

Appends filename to a local_path argument to avoid IsADirectoryError. Also updated documentation to be a bit more clear about the function and the parameter.

pep8speaks commented 5 months ago

Hello @snbianco! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-06-11 16:15:11 UTC
snbianco commented 5 months ago

@bsipocz

Hi! I'm Sam, a new developer at STScI working with @astrojimig. This is a PR to fix a bug in one of our methods.

bsipocz commented 5 months ago

minor note: unfortunately "address" is not one of the verbs that links an issue to a PR, pick one of close/fix/resolve instead :) https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#about-linked-issues-and-pull-requests