BUG: better handling the optional dependency required for functionality

astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8

http://astroquery.readthedocs.org/en/latest/

BSD 3-Clause "New" or "Revised" License

706 stars 399 forks source link

BUG: better handling the optional dependency required for functionality #3039

Closed bsipocz closed 5 months ago

bsipocz commented 5 months ago

One of the remote tests were failing when regions wasn't installed, which highlighted the case that we didn't handle the missing dependency well in the function too (e.g. the module should not fail if it's missing, but it should fail rather than just print a message when someone tries to use the method).

andamian commented 5 months ago

Sorry about this. Pretty sure I had it right but it probably got lost when I did the rebasing.

bsipocz commented 5 months ago

No worries, it should have been picked up by the review anyway, but I only noticed it as I saw the test failing today in an env where regions was not present.