Closed snbianco closed 4 months ago
Any chance of adding the filters and query criteria as optionals into
get_cloud_uris()
instead? Even if it means fully changing that method (as there were already issues with it, see the abandoned PR #2145Anyway, from the users' POV, I think it would be better to have one method than having multiple with very similar name and functionality.
I agree, that's a great idea. I don't think it should involve a huge rewrite of the method, but I will take a look at that abandoned PR probably sometime next week and see if I can wrap it up.
I moved the logic entirely into get_cloud_uris()
and incorporated the changes from #2145. This should be ready for another round of review!
Ok, the new commit should pass the tests. I also made a few minor changes to the documentation so that those are passing as well.
Added
mast.Observations.get_cloud_uris_query()
method so that given a set of query criteria and optional filters, the user receives a list of cloud data URIs for matching data products.Also added to documentation and remote unit tests.