search

astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
699 stars 397 forks source link

Remove photutils from Astroquery astrometry.net #3067

Closed mfixstsci closed 2 months ago

mfixstsci commented 2 months ago

This PR addresses #2782.

Currently astroquery/astrometry_net/core.py tries to import photutils.detection.DAOStarFinder and astropy.nddata.CCDData and will make decisions on how sources in the fits file passed to AstrometryNetClass are extracted. The following additions will prepare the photutils portion of the algorithm for removal with the goal that if a source catalog is not provided, that nova.astrometry.net will perform the source extraction.

Fixes: #2782.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.55%. Comparing base (f1890ac) to head (1f445f6). Report is 10 commits behind head on main.

Files Patch % Lines
astroquery/astrometry_net/core.py 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3067 +/- ## ======================================= Coverage 67.54% 67.55% ======================================= Files 233 233 Lines 18320 18327 +7 ======================================= + Hits 12375 12380 +5 - Misses 5945 5947 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bsipocz commented 2 months ago

@mfixstsci - Tip of the day, use these words to cross-link the issue and thus autoclose. Unfortunately 'address' is not part of the list:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

mfixstsci commented 2 months ago

@mfixstsci - Tip of the day, use these words to cross-link the issue and thus autoclose. Unfortunately 'address' is not part of the list:

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Thank you this is really useful!

pep8speaks commented 2 months ago

Hello @mfixstsci! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-07-14 17:22:20 UTC