search

astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
706 stars 399 forks source link

[SIMBAD] Add emtpy response warning #3068

Closed ManonMarchand closed 4 months ago

ManonMarchand commented 4 months ago

Hi astroquery devs,

This PR adds a NoResultWarning when a SIMBAD query returns an empty table. This should fix #3060 .

ManonMarchand commented 4 months ago

Oh? Could you show your local failure? I don't have any.

bsipocz commented 4 months ago

It's just messing around ELLIPSIS and whitespace, it really is a local issue most of the time.

But for this one, I see it in CI, too: https://github.com/astropy/astroquery/actions/runs/9814474694/job/27525866043#step:5:13186

(just restarted this run after merging a bunch of PRs this morning, so any failures your see there are on main)

ManonMarchand commented 4 months ago

Maybe I have something different in my config, because I see the failure the other way, and I patched the width of the output in https://github.com/astropy/astroquery/pull/3068/commits/9f65c6f87f59f0ef598c634e11c10e232d945e94 I'll have a look on my side too

bsipocz commented 4 months ago

I would say don't worry about it for now (or we should just patch things up for the weekly CI to have fewer issues, but then again it doesn't really matter. I'll open an issue upstream for doctestplus as ideally, we should handle it within it.

(Also, maybe you have an older pytest-doctestplus version? If yes, that may help to narrow down when and why this became a problem).