search

astropy / astroquery

Functions and classes to access online data resources. Maintainers: @keflavich and @bsipocz and @ceb8
http://astroquery.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
705 stars 397 forks source link

Make empty results consistent for all modules #944

Open bsipocz opened 7 years ago

bsipocz commented 7 years ago

Some of the modules returns an empty table when no result is found, while others (e.g. sdss) returns None.

pllim commented 7 years ago

I think empty table should be the proper result, as it is more explicit than None. Also, I have a habit to make queries that purposely return empty tables just to check if the service is alive.

bsipocz commented 7 years ago

Sure, I agree with that. Only run into the None in sdss (but it was a random rather than a systematic check), so it may be a remnant of its nonconformity.

bsipocz commented 1 year ago

This is a sub of https://github.com/astropy/astroquery/issues/1838, and one that can be most quickly fixed (e.g. we already do something about the empty results, just not the right thing)

This should be done for the next release that is focusing on a lot of cleanup.