search

astropy / astroscrappy

Speedy Cosmic Ray Annihilation Package in Python
70 stars 34 forks source link

Build with Numpy 2.0, remove setup.cfg and more #85

Closed saimn closed 6 months ago

saimn commented 7 months ago

@cmccully - with Numpy 2.0 coming soon we will need to publish new wheels built with Numpy 2.0 (so they will be compatible with both Numpy 1.x and 2.0).

Also did various infrastructure updates to get rid of warnings etc.

saimn commented 6 months ago

test_median_clean is failing when running tests for the cp311-win_amd64 wheel... Not the first time we have a problem with this test (#71, #82, https://github.com/astropy/astroscrappy/pull/66#issuecomment-973287545) so probably something that should be investigated more in detail, for now I will just mark it as xfail.

      def test_median_clean(testdata):
          imdata, crmask = testdata
          # Because our image only contains single cosmics, turn off
          # neighbor detection. Also, our cosmic rays are high enough
          # contrast that we can turn our detection threshold up.
          _mask, clean = detect_cosmics(imdata, readnoise=10., gain=1.0,
                                        sigclip=6, sigfrac=1.0, cleantype='median')

          assert (clean[crmask] != imdata[crmask]).sum() == crmask.sum()

          # Run it again on the clean data. We shouldn't find any new cosmic rays
          _mask2, _clean2 = detect_cosmics(clean, readnoise=10., gain=1.0,
                                           sigclip=6, sigfrac=1.0, cleantype='median')
  >       assert _mask2.sum() == 0
  E       assert 100 == 0
saimn commented 6 months ago

@cmccully - PR is ready, do you want to have a look ?

astrofrog commented 6 months ago

As this is mainly infrastructural, I think we should go ahead and merge so that other packages can work properly with Numpy 2.0. However, I don't have permission to merge, so need to find someone who does.

pllim commented 6 months ago

@astrofrog , I updated the team, you should be able to merge now.