astropy / conda-channel-astropy

Packages built for the astropy conda channel
5 stars 19 forks source link

sncosmo v1.5.0 #145

Closed kbarbary closed 7 years ago

kbarbary commented 7 years ago

Can we enable Python 3.6 builds as well?

Another question: For the extinction package (sncosmo dependency), conda-forge seems to build fine for osx-64 (https://anaconda.org/conda-forge/extinction/files). What was the issue here? Or does it matter, since we can use the conda-forge recipe?

mwcraig commented 7 years ago

Can we enable Python 3.6 builds as well?

Yes, please remove the restriction from requirements.yml for sncosmo.

: For the extinction package (sncosmo dependency), conda-forge seems to build fine for osx-64

Not sure what the issue was, please try removing the restriction and let's see what happens.

Also, could you please remove the version number from glueviz? That will copy over whatever the latest version is from conda-forge. It is glue causing (at least some of) the failures here.

If you want you could drop the version numbers from sncosmo and extinction too.

kbarbary commented 7 years ago

Doesn't seem to like the lack of versions: RuntimeError: Could not download sncosmo-None.tar.gz

mwcraig commented 7 years ago

Looks like I need to have a conversation with @mwcraig about how he made that work in https://github.com/openastronomy/conda-channel

🙄

bsipocz commented 7 years ago

Another question: For the extinction package (sncosmo dependency), conda-forge seems to build fine for osx-64 (https://anaconda.org/conda-forge/extinction/files). What was the issue here? Or does it matter, since we can use the conda-forge recipe?

I can't remember the exact details, but probably a dependency was missing for that version combination. It took anaconda/conda-forge a really long time to get the py3.6 builds ready.

mwcraig commented 7 years ago

@kbarbary -- sorry, I see the problem. I thought sncosmo was already on conda-forge, in which case we could drop the version here. It is not, so the sncosmo version needs to be added back in.

kbarbary commented 7 years ago

That seems to have fixed it.