search

astropy / coordinates-benchmark

Accuracy Benchmarks of different coordinate conversion codes. Maintainers: @astrojuanlu, @astrofrog, and @cdeil
https://www.astropy.org/coordinates-benchmark/summary.html
11 stars 12 forks source link

Big bugfix: report differences in arcsec, not deg #16

Closed cdeil closed 11 years ago

cdeil commented 11 years ago

I accidentally put differences in summary.txt and summary.html in deg instead of arc sec before.

Now it should be ok, but @astrofrog can you please double-check that I didn't make a stupid mistake again?

astrofrog commented 11 years ago

This looks good, and makes much more sense. I was a bit surprised that astropy now agreed with pyast to 1µas ;-) Feel free to merge!

cdeil commented 11 years ago

@astrofrog After merging you PR #15 I had to rebase on master and resolve conflicts in the summary files.

I think I did it correctly, but one thing that is not described at http://docs.astropy.org/en/latest/development/workflow/development_workflow.html is that one has to force push (i.e. add the -f option) when pushing to github. If this is correct, maybe this can be added?

astrofrog commented 11 years ago

@cdeil - yes, after rebasing one needs to force push. Feel free to submit a PR for that against the astropy repo.

cdeil commented 11 years ago

I don't know if the description is good, but https://github.com/astropy/astropy/pull/521 is what I came up with.