search

astropy / coordinates-benchmark

Accuracy Benchmarks of different coordinate conversion codes. Maintainers: @astrojuanlu, @astrofrog, and @cdeil
https://www.astropy.org/coordinates-benchmark/summary.html
11 stars 12 forks source link

Update IDL files #36

Closed astrofrog closed 4 years ago

astrofrog commented 10 years ago

The IDL files need updating to include all the current conversions. Any volunteers? :)

cdeil commented 9 years ago

@astrofrog IDL was already moved to a temp folder and not included in the benchmark in #42. This PR really removes the files (they are still in the git history) and updates the "tools" page to reflect this and leaves a note there that if someone wants to include IDL again in the future a pull request is welcome.

OK?

astrofrog commented 9 years ago

I think it would still be cool to include IDL tests (and potentially other non-Python tests) in future, so maybe it would be worth thinking now about where to store these kinds of result files in the new infrastructure.

Are the current IDL results not worth comparing to because they are no longer valid?

cdeil commented 9 years ago

The results are valid, but the ascii file format changed a bit, and I don't want to manually re-format them.

Adding IDL back would just mean implementing coordinates_benchmarks.tools.idl.transform_celestial, calling IDL via subprocess and then putting the results in the right format into output/tools/idl. Not a ton of work, but I don't want to do it because I've never used IDL and don't have a license for my laptop.

astrofrog commented 9 years ago

Could you send a message on the astropy-dev list to ask if someone is interested in doing it? I seems like a nice self-contained project and I'm sure someone would be interested in helping. If you want to remove this for now, that's fine, though we can also leave it as a starting point.

embray commented 9 years ago

Having IDL would definitely be good. Hopefully somebody can find the time to do it.