search

astropy / extension-helpers

Helpers to assist with building Python packages with compiled C/Cython extensions
https://extension-helpers.readthedocs.io
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Remove support for (undocumented) --compiler argument #36

Closed astrofrog closed 3 years ago

astrofrog commented 3 years ago

Before this PR, we allowed the compiler returned by get_compiler to be overridden by the --compiler command-line argument. This wasn't actually documented and removing support for this allows us to clean up quite a bit of code.

Needs to be rebased once https://github.com/astropy/extension-helpers/pull/34 is merged!

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (d0cd5ac) into master (653bbc5) will increase coverage by 6.87%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   74.16%   81.04%   +6.87%     
==========================================
  Files          10        4       -6     
  Lines         511      269     -242     
==========================================
- Hits          379      218     -161     
+ Misses        132       51      -81
Impacted Files Coverage Δ
extension_helpers/__init__.py 100.00% <100.00%> (ø)
extension_helpers/_openmp_helpers.py 88.03% <100.00%> (ø)
extension_helpers/_setup_helpers.py 66.32% <100.00%> (ø)
extension_helpers/_utils.py 92.00% <100.00%> (+28.98%) :arrow_up:
extension_helpers/tests/test_setup_helpers.py
extension_helpers/tests/test_openmp_helpers.py
extension_helpers/tests/__init__.py
extension_helpers/conftest.py

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 653bbc5...d0cd5ac. Read the comment docs.