Switch from Azure to GitHub Actions

[astrofrog]

I am trying out the new re-usable OpenAstronomy workflows. For now, I am using @ConorMacBride's fork for the tox testing. This also now adds a publish workflow.

Fixes https://github.com/astropy/extension-helpers/issues/8

[ConorMacBride]

The tox workflow is now merged so you should be able to use the OpenAstronomy main branch.

[codecov[bot]]

Codecov Report

Merging #37 (4cfc229) into main (cd990d7) will decrease coverage by 4.31%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   79.13%   74.82%   -4.32%     
==========================================
  Files           4        4              
  Lines         278      278              
==========================================
- Hits          220      208      -12     
- Misses         58       70      +12     

Impacted Files	Coverage Δ
extension_helpers/_utils.py	74.00% <0.00%> (-18.00%)	:arrow_down:
extension_helpers/_setup_helpers.py	64.28% <0.00%> (-2.05%)	:arrow_down:
extension_helpers/_openmp_helpers.py	87.17% <0.00%> (-0.86%)	:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[astrofrog]

@ConorMacBride - just curious, do you have any idea what could be happening in the Windows build here? (it's complaining about not finding the Visual C++ compiler which is needed to build a package with a C extension in the test - I'm curious why this wasn't an issue on Azure though)

[ConorMacBride]

It's saying "Microsoft Visual C++ 14.0 or greater is required" however that version should be installed in the windows-latest image: https://github.com/actions/virtual-environments/blob/main/images/win/Windows2022-Readme.md#microsoft-visual-c

Unless an environment variable is missing (or the test is run isolated from the default environment variables)?

[astrofrog]

Yeah I was wondering if it was a tox isolation thing - it's just curious because this didn't occur on Azure. I'll try and dig deeper.

[ConorMacBride]

Yeah, maybe disabling the tox isolation will make it work? Azure Pipelines is using the windows-2019 image (https://github.com/actions/virtual-environments/blob/win19/20220131.1/images/win/Windows2019-Readme.md) while GitHub Actions is using windows-2022. The windows job seems to expect OpenMP to be installed, although nether of these images lists that as being installed so how did it work before?

[saimn]

I think there was an issue with the recent Windows upgrade on Actions and the Visual C++ compiler. @pllim probably knows more ?

[pllim]

Yes, @lpsinger fixed it by downgrading to windows-2019

[ConorMacBride]

Should we temporarily downgrade Windows in the reusable workflows from windows-latest to windows-2019? Would it be worth adding a way to specify a custom image?

[lpsinger]

Yes, @lpsinger fixed it by downgrading to windows-2019

See https://github.com/actions/virtual-environments/issues/5141

[pllim]

You only have to downgrade if you are compiling C, so 🤷

[astrofrog]

@ConorMacBride - I think it's probably best to downgrade to windows-2019 for now, it's not like we really need the more recent version?

[astrofrog]

Ah I just saw https://github.com/OpenAstronomy/github-actions-workflows/pull/15

[ConorMacBride]

The pinned jinja2==2.10.3 in tox.ini is trying to import a name in a dependency which has now been removed. Is this pin needed? jinja2 is now used by pytest-mpl to produce HTML reports and sunpy is using pytest-mpl, although just running pytest --pyargs sunpy doesn't enable pytest-mpl, it still gets imported. Maybe the jinja import in pytest-mpl should be made made lazy?

[astrofrog]

@Cadair - just FYI I've set PYPI_TOKEN in the repo secrets

[Cadair]

We waiting for the first release to merge this?

[astrofrog]

I guess we might as well at this point as we should be able to tag the workflows so it will be a good test?

[astrofrog]

@Cadair - I've updated the ref for the workflows to v1, feel free to merge if the CI passes!