search

astropy / extension-helpers

Helpers to assist with building Python packages with compiled C/Cython extensions
https://extension-helpers.readthedocs.io
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Add documentation and tests for setup_helpers.pkg_config #5

Open astrofrog opened 5 years ago

astrofrog commented 5 years ago

The setup_helpers.pkg_config function is used in several of astropy's setup_package.py files, so we should keep it here, but it isn't tested or documented, so that will need to be fixed.

saimn commented 4 years ago

The function is simple enough, so I'm not sure if it is worth changing, but there is a python package wrapping pkg-config: https://github.com/matze/pkgconfig I saw it used by some package I don't remember. It is a single file so it could be bundled, which would also remove the need to test and document our version.

astrofrog commented 4 years ago

Oh interesting! Actually if we want to go down that road I suggest we just remove that from extension-helpers and have packages add pkgconfig to their pyproject.toml and use it directly. Is there any reason not to do that?

saimn commented 4 years ago

Oh yes indeed, that would be even simpler.

Cadair commented 4 years ago

:+1: for removing everything we can :grinning:

astrofrog commented 4 years ago

I won't have time to investigate this in the near future, but if one of you has time to take a look, feel free to open a PR to astropy core to demonstrate how we could use the pkgconfig package instead!