Closed astrofrog closed 11 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
908be0d
) 76.50% compared to head (1860773
) 75.00%.
Files | Patch % | Lines |
---|---|---|
extension_helpers/_openmp_helpers.py | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It's such a small test suite that I don't think there is any harm in doing coverage for all?
@astrofrog I may not be able to do a proper review for a couple days. I'm happy to come back then, but if you're in a hurry you have my blessing tu I merge.
(I accidentally hit the "approve" button, but I'd still like my comments addressed. Obviously I'm in favour of this PR)
@pllim @neutrinoceros - I think I have implemented your comments, this is ready for a final review!
(rebased following merging of other PRs)
@pllim - does this seem ok now?
Errr the conda jobs are failing... Was it my fault?
ERROR: pyproject.toml file found.
I'll look into it later this week!
@astrofrog , I took the liberty to push a couple of commits here. CI is green now but I'll let you have a look. If you are okay with my changes, feel free to merge. Thanks!
Thanks!
This migrates the configuration from setup.cfg to pyproject.toml, adds ruff, sp-repo-review, and implements many of the suggestions of the latter.