astropy / extension-helpers

Helpers to assist with building Python packages with compiled C/Cython extensions
https://extension-helpers.readthedocs.io
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Infrastructure updates #68

Closed astrofrog closed 11 months ago

astrofrog commented 11 months ago

This migrates the configuration from setup.cfg to pyproject.toml, adds ruff, sp-repo-review, and implements many of the suggestions of the latter.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (908be0d) 76.50% compared to head (1860773) 75.00%.

Files Patch % Lines
extension_helpers/_openmp_helpers.py 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #68 +/- ## ========================================== - Coverage 76.50% 75.00% -1.51% ========================================== Files 4 4 Lines 315 316 +1 ========================================== - Hits 241 237 -4 - Misses 74 79 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

astrofrog commented 11 months ago

It's such a small test suite that I don't think there is any harm in doing coverage for all?

neutrinoceros commented 11 months ago

@astrofrog I may not be able to do a proper review for a couple days. I'm happy to come back then, but if you're in a hurry you have my blessing tu I merge.

neutrinoceros commented 11 months ago

(I accidentally hit the "approve" button, but I'd still like my comments addressed. Obviously I'm in favour of this PR)

astrofrog commented 11 months ago

@pllim @neutrinoceros - I think I have implemented your comments, this is ready for a final review!

astrofrog commented 11 months ago

(rebased following merging of other PRs)

astrofrog commented 11 months ago

@pllim - does this seem ok now?

pllim commented 11 months ago

Errr the conda jobs are failing... Was it my fault?

ERROR: pyproject.toml file found.

astrofrog commented 11 months ago

I'll look into it later this week!

pllim commented 11 months ago

@astrofrog , I took the liberty to push a couple of commits here. CI is green now but I'll let you have a look. If you are okay with my changes, feel free to merge. Thanks!

astrofrog commented 11 months ago

Thanks!