Lacosmicx

[cmccully]

I have finished the optimized LA Cosmic implementation. It uses Cython for the main part of the algorithm and uses C for the individual routines. Everything is multithreaded using OpenMP (the Cython standard). For a 4K x 2K image, this implementation is ~35 times faster than cosmics.py written by Malte Tewes (which is already significantly faster than the original IRAF version).

Given the complexity of this code, should this be included in imageutils or should it be its own package?

Any other comments are welcome.

[eteq]

I talked to him yesterday, and then sent him an e-mail to get it in writing (and answer a few questions about our license), and he hasn't replied yet. It's possible he's left for break...? Will try pinging him again.

[cmccully]

I am happy to refactor this code, but I won't have much time until next week after the holiday. Do you want to include that in this pull request or should we merge this and then refactor in a separate pull request?

[astrofrog]

@cmccully - we can do the refactoring in a separate pull request. Let's just wait for @eteq to give a go-ahead.

[eteq]

I suspect that will also have to wait until after the holiday, as I still haven't heard back.

[astrofrog]

@eteq - any updates on this?

[larrybradley]

Any updates on the licensing issue?

[coveralls]

Coverage increased (+0.07%) to 94.1% when pulling 90fa0bf2540ea8827734a1edfcd3b20d2f7d84ce on cmccully:lacosmicx into 3eafeb62cba5c3da44c04f2aaaf88fb4b84a8f5e on astropy:master.

[cmccully]

The travis build now fails for two of the tests saying jinja2 is not installed. I think I am using the most up to date build of imageutils master. Anyone know how to fix this? Thanks.

[astrofrog]

@cmccully - in the file .travis.yml there is a line that says:

- if [[ $SETUP_CMD != egg_info ]]; then $CONDA_INSTALL numpy=$NUMPY_VERSION pytest pip Cython; fi

add jinja2 just after Cython, so:

- if [[ $SETUP_CMD != egg_info ]]; then $CONDA_INSTALL numpy=$NUMPY_VERSION pytest pip Cython jinja2; fi

basically jinja2 is now required to build the developer version of Astropy.

[astrofrog]

@eteq - any updates on the licensing issue?

[coveralls]

Coverage increased (+0.07%) to 94.1% when pulling d4caa56eae2513fd8670e3468e5161be3b2f6383 on cmccully:lacosmicx into 3eafeb62cba5c3da44c04f2aaaf88fb4b84a8f5e on astropy:master.

[mwcraig]

@eteq @astrofrog -- friendly bump...we are waiting for this to land somewhere so we remove functionality that duplicates this (but runs much more slowly) in ccdproc

[larrybradley]

lacosmic is now in the astroscrappy package.