search

astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 62 forks source link

Move as much configuration as possible to setup.cfg #375

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

I need to actually check this works, including for example the package data option. Also note that this requires that setuptools be more recent than 2 years old (see https://github.com/astropy/astropy/pull/8240)

(this is part of a series of PRs to simplify setup.py)

bsipocz commented 5 years ago

Could you mention the setuptools version requirement change in the changelog, please?

astrofrog commented 5 years ago

Yes, will do!

astrofrog commented 5 years ago

I think https://github.com/astropy/astropy-helpers/issues/438 will help simplify things further.

astrofrog commented 5 years ago

⚠️ this contains temporary commits and should not be merged! ⚠️

I've now simplified the setup.py file as much as possible given the new improvements in astropy-helpers. Note that since the astropy-helpers improvements won't be backported to 2.0.x, these changes are Python 3-only so we should resolve #385 first.

astrofrog commented 5 years ago

Rebased on #385 for now. Still needs some cleanup which I'll try and do later today.

bsipocz commented 5 years ago

@astrofrog - dependency PRs have been merged, could you please have a look how this stands now?

astrofrog commented 5 years ago

@bsipocz @Cadair - rebased, and I think good to go, but let's see what Travis says. Feel free to review again and optionally take this for a spin, or we could just merge and then do follow up PRs if needed.

pllim commented 5 years ago

this contains temporary commits and should not be merged!

Is this still true? Seems to contradict Slack message that this is ready. Just making sure.

astrofrog commented 5 years ago

I’ve removed the temp commits!

bsipocz commented 5 years ago

OK, let's go ahead and merge this now. Thanks @astrofrog!