search

astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 63 forks source link

Use RTD v2 #432

Closed pllim closed 4 years ago

pllim commented 4 years ago

Fix #429

Fix #431

bsipocz commented 4 years ago

This looks good to me. The comments are rhetorical ones really, I suppose I'm happy to merge this as is.

astrofrog commented 4 years ago

What if we declared an extras requires for docs in setup.cfg and put Sphinx-astropy there, then used that in the RTD config? Would be more consistent with the core package than using a rtd requirements file?

astrofrog commented 4 years ago

Just to be clear I’m ok with this being merged and happy to do a follow up PR

pllim commented 4 years ago

Would be more consistent with the core package than using a rtd requirements file?

The core still uses a RTD requirements file on top of the setup.cfg to pin matplotlib. :grimacing:

https://github.com/astropy/astropy/blob/4c46eb6b09c65b6e66db7d1a8a4b2a40224482bc/docs/rtd_requirements.txt#L1

I agree that using setup.cfg is a separate PR.

pllim commented 4 years ago

Feel free to merge if you are okay with this. I try not to merge my own PRs. :wink:

Cadair commented 4 years ago

On the [docs] extras require point, we found in SunPy that we needed to be able to specify things specific to RTD before, which made extras require not a perfect solution. I don't know if that's a concern we want to carry into the package template though.

pllim commented 4 years ago

@Cadair , I am not using [docs] thingy here... am I?

Cadair commented 4 years ago

No, I was responding to @astrofrog's comments.

pllim commented 4 years ago

Superseded by #438