Closed pllim closed 4 years ago
This looks good to me. The comments are rhetorical ones really, I suppose I'm happy to merge this as is.
What if we declared an extras requires for docs in setup.cfg and put Sphinx-astropy there, then used that in the RTD config? Would be more consistent with the core package than using a rtd requirements file?
Just to be clear I’m ok with this being merged and happy to do a follow up PR
Would be more consistent with the core package than using a rtd requirements file?
The core still uses a RTD requirements file on top of the setup.cfg
to pin matplotlib
. :grimacing:
I agree that using setup.cfg
is a separate PR.
Feel free to merge if you are okay with this. I try not to merge my own PRs. :wink:
On the [docs]
extras require point, we found in SunPy that we needed to be able to specify things specific to RTD before, which made extras require not a perfect solution. I don't know if that's a concern we want to carry into the package template though.
@Cadair , I am not using [docs]
thingy here... am I?
No, I was responding to @astrofrog's comments.
Superseded by #438
Fix #429
Fix #431