Closed mhvk closed 3 years ago
I guess issue #368 partially answers this - but even more reason to update the docs!
Yes, I suppose we've switched to codecov everywhere now, but updating the docs might have lost in the weeds.
Any idea what those extra lines do? (Added by @saimn, so pinging...)
No, I'm not exactly sure why that env variable needs to be exported as oppose to the other jobs. Arguably @saimn's changes were originated from https://github.com/astropy/astropy/pull/8248/files, but even there I see no trace of mentioning the xml, neither the export of the variable. Maybe @astrofrog can shed light on the question?
Also, does anyone know how to get rid of the coveralls
in the checks for a PR? (I promise I'll make a PR for the template docs!)
I think it should be listed as a webhook
in the settings menu of the project's repo. Delete the webhook and it should be fine (along with the changes in the travis config, etc, along the ones made in e.g. https://github.com/astropy/astropy/pull/7879)
(if it's not there, pls let me know, it was just a guess, as I don't think I have access to any settings any more that still uses coveralls).
Either webhook or app, I can't remember now, but I do remember it is on the admin panel.
Thanks for the tips - it turned out I also needed to remove coveralls in "branches", in the protection of the master branch.
I think we use codecov now? Is this still relevant?
No, I don't think so, so closing.
Probably I'm just missing things, but astropy's
.travis.yml
has more lines about coverage than the template here; in particular,Is this important?
Also, we use what seems a new package,
codecov
- does this still push tocoveralls.io
? Would be good to update "next steps" to be clear about it (which I'm happy to do, but I need to be clear about it first!).