astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 63 forks source link

Remove cextern directory based on input #446

Closed larrybradley closed 4 years ago

larrybradley commented 4 years ago

Currently the cextern directory is always created and thus include_cextern_folder has no effect.

fixes https://github.com/astropy/package-template/issues/403

astrofrog commented 4 years ago

I wonder whether we even still need this option - 99% of packages won't need this. What do people think about just removing it altogether?

pllim commented 4 years ago

FWIW removing it should be a separate PR. This is a simple fix to an existing feature, so I'd vote for accepting it as-is.