search

astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 63 forks source link

use Major.minor syntax #487

Closed nstarman closed 3 years ago

nstarman commented 3 years ago

A very small change from x.y.z to X.Y.Z, to better follow the semantic versioning standard syntax.

edit: changed. see history.

Signed-off-by: Nathaniel Starkman nstarkman@protonmail.com

bsipocz commented 3 years ago

The astropy docs also keeps using the non capitalized, so I don't see the reason to change it t upper case here, tbh.

bsipocz commented 3 years ago

(After all it's not proper semver to begin with)

pllim commented 3 years ago

If the capitalization makes it more consistent with Python org docs, doesn't hurt? Python is case-sensitive after all.

pllim commented 3 years ago

@bsipocz , can I merge this or should I leave it open for further discussions? Please advise. Thanks!

bsipocz commented 3 years ago

Being consistent with Python docs is indeed good here, so if @nstarman you feel like it, please open a PR to astropy core to change the cases to upper ones there, too.

Thanks!

nstarman commented 3 years ago

Being consistent with Python docs is indeed good here, so if @nstarman you feel like it, please open a PR to astropy core to change the cases to upper ones there, too.

Thanks @bsipocz. I will do that now.