search

astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 63 forks source link

`package_data` in APE 17 migration guide #513

Closed epassaro closed 3 years ago

epassaro commented 3 years ago

Followed the migration guide and the package_data was not included.

I needed to add include_package_data = True under [options].

Then, it worked.

pllim commented 3 years ago

But it is in the template:

https://github.com/astropy/package-template/blob/bf8ce319e8ec99c38ab80c8af8c0437c16de0474/%7B%7B%20cookiecutter.package_name%20%7D%7D/setup.cfg#L42-L43

astrofrog commented 3 years ago

The include_package_data option actually bypasses the package_data option and uses the manifest instead so you should either use include_package_data or package_data but not both. If the latter doesn't work, there might be a syntax or path issue in it. Could you post a link to your setup.cfg file?

epassaro commented 3 years ago

This is the working setup.cfg: https://github.com/epassaro/tardis/blob/ape-17-migration/setup.cfg

This is the (untouched from template) MANIFEST.in: https://github.com/epassaro/tardis/blob/ape-17-migration/MANIFEST.in

epassaro commented 3 years ago

Please ignore this issue. Closing.