astropy / package-template

Template for packages that use Astropy. Maintainer: @astrofrog
http://docs.astropy.org/projects/package-template/en/latest/
Other
60 stars 63 forks source link

Package Next Steps #519

Closed nstarman closed 11 months ago

nstarman commented 2 years ago

In today's dev telecon we discussed https://github.com/astropy/package-template/ and it's future given that there is also Python Packaging Guide. See the telecon notes (included below) for details. In brief, the suggestions are:

  1. Add a message to package_template that we are considering a move to the OA template. The message should probably be added to both the README and the cookie-cutter. See #520
  2. Recommending users to use to Python Packaging Guide while package_template is reorganized. Blocked by:
    • OpenAstronomy/packaging-guide#23
  3. Add documentation how to add Astropy infrastructure on top of Python Packaging Guide, so that affiliate packages can still make astropy-compatible packages.
  4. Funded project proposal for keeping these steps up-to-date, or ideally making a sub-branch or “astropy method” in the OA package template.

Quoting from the Dev Telecon:


Status of the astropy package template: Should it be retired in favor of Python Packaging Guide? There is much overlap between the OA guide and the package template, so in the long term it might be good not to have both. However, is there feature parity? Is a migration needed? Should we formally deprecate astropy-template and ask people to migrate? Or should we simply not update it any longer? Or maybe keep both because they are different? MHvK: can we perhaps make a migration guide? And then deprecate the astropy template? The discussion in the issue is stalled, so it seems good to bring it up here to make a decision or suggestion on how to proceed.

weaverba137 commented 2 years ago

One comment about the Python Packaging Guide: entire top-level sections of the documentation "Needs writing!". Literally: https://packaging-guide.openastronomy.org/en/latest/scripts.html. I would be hesitant to recommend the template until at least all documentation is filled in.

pllim commented 2 years ago

Good point, @weaverba137 ! I opened issue at OpenAstronomy/packaging-guide#23. cc @Cadair

Cadair commented 2 years ago

PRs welcome ;) (you could always just remove the placeholders then you never would have complained :wink: )

pllim commented 2 years ago

just remove the placeholders

As in, completely remove those pages?

weaverba137 commented 2 years ago

I think the documentation of command-line scripts is quite important, and should be filled out rather than removed.

Cadair commented 2 years ago

I think the documentation of command-line scripts is quite important, and should be filled out rather than removed.

Not suggesting it isn't.

pllim commented 1 year ago

What about this? https://github.com/scikit-hep/cookie

pllim commented 1 year ago

I merged https://github.com/astropy/package-template/pull/520 but the OpenAstronomy needs to find someone to clean up the template documentation over there.

pllim commented 11 months ago

It's been a while since we started this, so I upgraded the "pending deprecation warning" to "deprecation warning" in README. I will also close issues and PRs not related to the transition as won't fix to drive the point across.