search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

Add changelog entries from PR #100 #104

Closed sargas closed 7 years ago

sargas commented 7 years ago

PR to note the changes that #97 would have done, and warn about changing science results.

cdeil commented 7 years ago

👍

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.13% when pulling d594f179a4c2fda1506a5b7b9dec0553892e3919 on sargas:add-distortionaware-to-changes into 3cef81961eeaa6df902534f4f20996d5033603b6 on astropy:master.

sargas commented 7 years ago

I managed to change the API in another way that's undocumented: WCS objects are not sufficient for conversion to image coordinates.

This is because angles are defined based on the rotation of the north axis onto the pixel plane, as measured by the center of the FITS image. It would make more sense to me to make it at the center of the shape in question, or even based on CRPIX[12], but this is how DS9 does it. Added the documentation update to this PR.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.13% when pulling b62cc031cde0626b0241335e7b77fab2ce75fd28 on sargas:add-distortionaware-to-changes into 3cef81961eeaa6df902534f4f20996d5033603b6 on astropy:master.

cdeil commented 7 years ago

@sargas - Why wasn't this merged? Is it ready to go? (if yes, just go ahead and merge, please)

bsipocz commented 7 years ago

I take the blame, and push the button now...

cdeil commented 7 years ago

@sargas and @bsipocz - Thanks!