search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

Another small writer fix #110

Closed keflavich closed 7 years ago

keflavich commented 7 years ago

From the commit: another fix to the writer: the open function only accepts one argument. How did this ever work?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.13% when pulling bc12dcafbfd249f0b734d71db1d6be7a05105f74 on keflavich:another_writer_fix into 1ed46731eedffcb52910b0574b2a4e7a8cc99a7d on astropy:master.

cdeil commented 7 years ago

@keflavich - Thanks! Merging this now.

I don't know if this was always broken or if a regression happened. This is for the case of an empty shapelist, so probably very rarely executed by users. And the whole write method as well as very large parts of pyregion/core.py are not covered by tests: https://coveralls.io/builds/11110671/source?filename=pyregion%2Fcore.py#L160

Of course more tests would be important / welcome, see #44.