search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

add a test case for radio cubes #113

Closed leejjoon closed 6 years ago

leejjoon commented 7 years ago

This is a simple test case for a header of 3d cube.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.295% when pulling a4983ec1e15782200ae0042f155a6f0d843370b8 on leejjoon:fix-cube2 into 7ad0106cd2958b621cdacd495fa5414f9ba49363 on astropy:master.

cdeil commented 7 years ago

@leejjoon - Thanks!

I plan to make the pyregion 2.0 release tomorrow and this is ready to go in. If you have time, one suggestion I have would be to add an assert (using numpy.testing.assert_allclose on the result, at the end of the test (to establish the current behaviour).

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 63.504% when pulling 918fcb03802ab3e1bc3bb996728e1b14e117f2f6 on leejjoon:fix-cube2 into 7ad0106cd2958b621cdacd495fa5414f9ba49363 on astropy:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.2%) to 63.504% when pulling 48a14d54bda26b7dc8d9c4897f2101dc77cc304b on leejjoon:fix-cube2 into 7ad0106cd2958b621cdacd495fa5414f9ba49363 on astropy:master.

cdeil commented 6 years ago

@leejjoon - I'm merging in this old PR from you now. Thanks!