astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

Update astropy-helpers to v2.0 #115

Closed bsipocz closed 6 years ago

bsipocz commented 6 years ago

This is an automated update of the astropy-helpers submodule to v2.0. This includes both the update of the astropy-helpers sub-module, and the ah_bootstrap.py file, if needed.

This is intended to be helpful, but if you would prefer to manage these updates yourself, or if you notice any issues with this automated update, please let @bsipocz or @astrofrog know!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 63.295% when pulling 518e46f74256f275d643188f81cdaf50f8fa7736 on bsipocz:update-helpers-v2.0 into cda4f12b16971ff445b4ff92b97efb606ded4edf on astropy:master.

cdeil commented 6 years ago

@bsipocz - There's this one fail: https://travis-ci.org/astropy/pyregion/jobs/251343046#L679

/home/travis/build/astropy/pyregion/docs/examples.rst:20: WARNING: Exception occurred in plotting demo_region03
 from /home/travis/build/astropy/pyregion/docs/examples/demo_region03.py:
Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test/lib/python3.5/site-packages/matplotlib/sphinxext/plot_directive.py", line 520, in run_code
    six.exec_(code, ns)
  File "<string>", line 5, in <module>
  File "/home/travis/miniconda/envs/test/lib/python3.5/site-packages/wcsaxes/__init__.py", line 18, in <module>
    from .patches import *
  File "/home/travis/miniconda/envs/test/lib/python3.5/site-packages/wcsaxes/patches.py", line 10, in <module>
    from astropy.coordinates.angles import rotation_matrix
ImportError: cannot import name 'rotation_matrix'

I think maybe the proper fix is to remove the install of the external wcsaxes package here, no? https://github.com/astropy/pyregion/blob/master/.travis.yml#L41

@bsipocz - Can you do it here as an extra commit or should I?

cdeil commented 6 years ago

@bsipocz - I see now you've split this out into #116 . I'm merging this now and will update the wcsaxes usage in a separate PR.