search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

ascircle region? #121

Closed cdeil closed 1 year ago

cdeil commented 6 years ago

If you run the tests, there's a warning:

lib.macosx-10.13-x86_64-3.6/pyregion/tests/test_region.py::test_open_regions[test01.reg]
  /private/var/folders/sb/4qv5j4m90pz1rw7m70rj1b1r0000gn/T/pyregion-test-sqxvhoqr/lib.macosx-10.13-x86_64-3.6/pyregion/ds9_region_parser.py:107: UserWarning: Failed to parse : ascircle(171.10096,-59.250612,18.510811") # color=cyan
    warnings.warn("Failed to parse : " + l)

There is this region in examples/test01.reg and pyregion/tests/data/test01.reg:

ascircle(171.10096,-59.250612,18.510811") # color=cyan

https://github.com/astropy/pyregion/search?utf8=%E2%9C%93&q=ascircle&type=

@sargas @leejjoon @keflavich @astrofrog - Does anyone know what that region is about?

There is no ascircle listed here: http://ds9.si.edu/doc/ref/region.html

Is this supposed to be an example of a region that doesn't exist, to see if the correct warning is raised? If yes: I could just split that test out in #120 and check for the warning.

leejjoon commented 6 years ago

According to the history, It seems that it was a typo that is not meant to be committed. Originally it was "circle" then it was changed to "ascircle" with no reason (2a8f00296784ba3adcc023dad631e7693362d899). I guess it is best to change it back to "circle".