Remove docs example using internal pyregion._region_filter

astropy / pyregion

ds9 region parser for python

https://pyregion.readthedocs.io

MIT License

39 stars 38 forks source link

Remove docs example using internal pyregion._region_filter #130

Closed cdeil closed 6 years ago

cdeil commented 6 years ago

Fixes #129 .

coveralls commented 6 years ago

Coverage remained the same at 63.542% when pulling fdd07b2dac166783f905a3f7c6bcee2402e16a2b on cdeil:issue-129 into 7487ba85119daca7b4a63bf493b6ae2d69e498dc on astropy:master.

cdeil commented 6 years ago

I'll just merge this now. @leejjoon or anyone - of course comments or follow-up PRs to improve the docs are welcome any time.

cdeil commented 6 years ago

Oh boy: https://travis-ci.org/astropy/pyregion/jobs/373880714#L838

@bsipocz - Thoughts? How about just removing the build against that old Numpy version?

bsipocz commented 6 years ago

Yeah, dropping it sounds fine by me, but if you want to keep it, the workaround is to use ASTROPY_VERSION=1.3 in that build.

cdeil commented 6 years ago

I removed the old Numpy 1.8 build from .travis.yml via fc3b979 in master.