search

astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

Update astropy-helpers to v2.0.8 #132

Closed bsipocz closed 5 years ago

bsipocz commented 5 years ago

This is an automated update of the astropy-helpers submodule to v2.0.8. This includes both the update of the astropy-helpers sub-module, and the ah_bootstrap.py file, if needed.

A full list of changes can be found in the changelog.

This is intended to be helpful, but if you would prefer to manage these updates yourself, or if you notice any issues with this automated update, please let @bsipocz or @astrofrog know!

Similarly to the core package, the v3.0+ releases of astropy-helpers require Python 3.5+. We will open automated update PRs with astropy-helpers v3.1.x only for packages that specifically opt in for it when they start supporting Python 3.5+ only. Please let @bsipocz or @astrofrog know or add your package to the list in https://github.com/astropy/astropy-procedures/blob/master/update-affiliated/helpers_3.py

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 63.768% when pulling e16c82c915172cac38a1e37248af902d5b9e08f7 on bsipocz:update-helpers-v2.0.8 into 913af7ea4917855cb2e43d5086d1c8dd99c31363 on astropy:master.

cdeil commented 5 years ago

@bsipocz @astrofrog Python 2.7 on Windows fails like this!?

INTERNALERROR> DeprecationWarning: The `implprefix` system is deprecated please decorate this function using an instance of HookimplMarker.

https://ci.appveyor.com/project/Astropy/pyregion/builds/20949480/job/7woh3u1gxhe0tvkv#L521

bsipocz commented 5 years ago

Apparently it does 😄

More seriously. In astroplan and stingray there are segfault like hang ups on windows and python 2.7 (neither case have been solved), but I haven't yet seen this INTERNALERROR in any other packages. I'll cross ref if see something related elsewhere.

cdeil commented 5 years ago

I restarted the Appveyor build and it still fails on Python 2.7 on Windows with this error:

INTERNALERROR> DeprecationWarning: The `implprefix` system is deprecated please decorate this function using an instance of HookimplMarker.

@bsipocz or @astrofrog or @mwcraig - Have you seen that before, or any idea what causes this or how to fix it?

cdeil commented 5 years ago

Closing this old PR. Presumably superseded by #135 .