Return ShapeList instead of Python list consistently

astropy / pyregion

ds9 region parser for python

https://pyregion.readthedocs.io

MIT License

39 stars 38 forks source link

Return ShapeList instead of Python list consistently #85

Closed cdeil closed 7 years ago

cdeil commented 7 years ago

This PR changes read_region and read_region_as_imagecoord to return a ShapeList instead of a Python list.

I guess this isn't really needed, but for consistency within the pyregion API maybe ShapeList should be used throughout?

This shouldn't break any user's code except if they did explicitly isinstance(shapes, list), which I guess is unlikely and an acceptable change for 1.2?

But I'm not sure, so @leejjoon - assigning this PR to you for review / decision.

coveralls commented 7 years ago

Coverage decreased (-0.05%) to 50.66% when pulling 29872221daf3dc6ec55e25f105ec1f0bac5e0c6f on cdeil:more-shapelist into 1304632aaa0e2098daaa17d16b177061fe44b1e0 on astropy:master.