astropy / pyregion

ds9 region parser for python
https://pyregion.readthedocs.io
MIT License
39 stars 38 forks source link

changelog_links doesn't work for pyregion #92

Closed cdeil closed 7 years ago

cdeil commented 7 years ago

While adding #91 I noticed that changelog_links doesn't work for pyregion.

If I change

- Change tag attribute from string to list of strings [26]

to

- Change tag attribute from string to list of strings [#26]

in CHANGES.rst, I get the following error (with Python 3.5):

[changelog_links] Adding changelog links to "changelog"                        
Traceback (most recent call last):
  File "<stdin>", line 31, in <module>
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/application.py", line 291, in build
    self.builder.build_all()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 211, in build_all
    self.build(None, summary='all source files', method='all')
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 322, in build
    self.write(docnames, list(updated_docnames), method)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 360, in write
    self._write_serial(sorted(docnames), warnings)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/builders/__init__.py", line 366, in _write_serial
    doctree = self.env.get_and_resolve_doctree(docname, self)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/environment.py", line 1278, in get_and_resolve_doctree
    self.resolve_references(doctree, docname, builder)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/environment.py", line 1563, in resolve_references
    builder.app.emit('doctree-resolved', doctree, fromdocname)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/sphinx/application.py", line 551, in emit
    results.append(callback(self, *args))
  File "/Users/deil/code/pyregion/astropy_helpers/astropy_helpers/sphinx/ext/changelog_links.py", line 48, in process_changelog_links
    refuri = app.config.github_issues_url + issue_number[1:]
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'
Sphinx Documentation subprocess failed with return code 1

@bsipocz - Help!?