search

astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data
BSD 3-Clause "New" or "Revised" License
23 stars 15 forks source link

Either fix internet_off or add a new decorator to disable internet #17

Open drdavella opened 7 years ago

drdavella commented 7 years ago

Currently the internet_off decorator indicates that a test will only run if --remote-data is not provided or --remote-data=none. It would be more useful to have a decorator that actually disables network access for the scope of that test.

To accomplish this we could either update internet_off, or we could add a new decorator (maybe disable_internet). As far as I know, no one is using internet_off yet, so we probably don't have to worry about API breakage.

drdavella commented 7 years ago

It will be necessary to update the astropy testing documentation if/when this change is made.

pllim commented 4 years ago

This doesn't behave as expected in pytest 5.3 either. Works when I run it manually in interpreter but not when I invoke the test with pytest testfile. 🤷‍♀ 

with no_internet():
    something_that_downloads()