Add github option and fix IP lookup error for astropy option

astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data

BSD 3-Clause "New" or "Revised" License

23 stars 15 forks source link

Add github option and fix IP lookup error for astropy option #28

Closed pllim closed 6 years ago

pllim commented 6 years ago

Fix source='astropy' not taking account for IP aliases -- https://help.github.com/articles/setting-up-an-apex-domain/
Resolve IP in a way that is compatible with both IPv4 and IPv6.
Add a source='github' option.

This is as discussed with @astrofrog on Slack. I know I mixed in bug fix and a new feature, so let me know if you want me to split this into two PRs.

pllim commented 6 years ago

Tests passed. Please review.

pllim commented 6 years ago

One way to make it more general is to turn the hosts into a single configurable item. Then we are down to 3 options:

none
any
custom (because it won't make sense to call it "astropy" anymore)

However, that also involves refactoring of packages that use this plugin. :thinking:

If you are really uncomfortable with the extra "github" option, I can take it back out.

drdavella commented 6 years ago

@pllim I think it's fine just to add all of this to v0.3 since I doubt any users are pinning minor release versions anyway. Can you please add a change log entry?

drdavella commented 6 years ago

@pllim I just rebased this: can you take a look for a quick sanity check?

pllim commented 6 years ago

@drdavella thanks! I just pushed another commit. If this doesn't break the tests, it is good to merge.