astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data
BSD 3-Clause "New" or "Revised" License
23 stars 15 forks source link

Deprecation warnings with pytest 3.8 #35

Closed astrofrog closed 5 years ago

astrofrog commented 6 years ago

I'm seeing the following deprecation warnings when using pytest-remotedata with pytest 3.8:

/Users/tom/miniconda3/envs/dev/lib/python3.7/site-packages/pytest_remotedata/plugin.py:73: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  if len(remote_data.args) > 0:
/Users/tom/miniconda3/envs/dev/lib/python3.7/site-packages/pytest_remotedata/plugin.py:76: RemovedInPytest4Warning: MarkInfo objects are deprecated as they contain merged marks which are hard to deal with correctly.
Please use node.get_closest_marker(name) or node.iter_markers(name).
Docs: https://docs.pytest.org/en/latest/mark.html#updating-code
  source = remote_data.kwargs.get('source', 'any')
drdavella commented 6 years ago

@astrofrog I believe this was resolved by https://github.com/astropy/pytest-remotedata/pull/34, but the update hasn't propagated to pytest-astropy yet. In fact, I still think we're waiting on https://github.com/conda-forge/pytest-remotedata-feedstock/pull/4 to be merged.

astrofrog commented 6 years ago

@drdavella - I've merged it. Btw it's usually sufficient to wait for the automated conda-forge PR to be opened: https://github.com/conda-forge/pytest-remotedata-feedstock/pull/5

bsipocz commented 5 years ago

This has been resolved.