astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data
BSD 3-Clause "New" or "Revised" License
23 stars 15 forks source link

pytest-remotedata is not compatible with dev versioning of pytest #39

Closed bsipocz closed 5 years ago

bsipocz commented 5 years ago

The pytest version number for the developer branch is not compatible with StrictVersion, and thus I run into tons of errors like the one below when tried to use pytest dev with astropy core.

I don't see a reason of why StrictVersion is preferred instead of LooseVersion. If there is something I miss @drdavella please let me know.

____________________________________________________ ERROR at setup of test_numpy_types[c5] _____________________________________________________

item = <Function test_numpy_types[c5]>

    def pytest_runtest_setup(item):

>       if StrictVersion(pytest.__version__) < StrictVersion("3.6"):

/usr/local/lib/python3.7/site-packages/pytest_remotedata/plugin.py:65: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/version.py:40: in __init__
    self.parse(vstring)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <[AttributeError("'StrictVersion' object has no attribute 'version'") raised in repr()] StrictVersion object at 0x13a052c88>
vstring = '5.0.1.dev15+g5d8da88e9.d20190702'

    def parse (self, vstring):
        match = self.version_re.match(vstring)
        if not match:
>           raise ValueError("invalid version number '%s'" % vstring)
E           ValueError: invalid version number '5.0.1.dev15+g5d8da88e9.d20190702'

/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/distutils/version.py:137: ValueError