search

astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data
BSD 3-Clause "New" or "Revised" License
23 stars 15 forks source link

DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead server.setDaemon(True) #68

Closed Hellseher closed 1 year ago

Hellseher commented 1 year ago

Hi,

During update package for Guix I've noticed this warning:

Using pytest
Internet access disabled
============================= test session starts ==============================
platform linux -- Python 3.10.7, pytest-7.1.3, pluggy-1.0.0 -- /gnu/store/l6fpy0i9hlll9b6k8vy2i2a4cshwz3cv-python-wrapper-3.10.7/bin/python
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/tmp/guix-build-python-pytest-remotedata-0.4.0.drv-0/pytest-remotedata-0.4.0/.hypothesis/examples')
rootdir: /tmp/guix-build-python-pytest-remotedata-0.4.0.drv-0/pytest-remotedata-0.4.0, configfile: setup.cfg, testpaths: tests
plugins: hypothesis-6.54.5, remotedata-0.4.0
collecting ... collected 15 items / 3 deselected / 12 selected

tests/test_skip_remote_data.py::test_skip_remote_data SKIPPED (need --remote-data option to run) [  8%]
tests/test_skip_remote_data.py::test_skip_remote_data_astropy SKIPPED (need --remote-data option to run) [ 16%]
tests/test_skip_remote_data.py::test_skip_remote_data_github SKIPPED (need --remote-data option to run) [ 25%]
tests/test_skip_remote_data.py::test_internet_off_decorator PASSED       [ 33%]
tests/test_skip_remote_data.py::test_block_internet_connection PASSED    [ 41%]
tests/test_skip_remote_data.py::test_block_internet_connection_internet_off PASSED [ 50%]
tests/test_socketblocker.py::test_outgoing_fails PASSED                  [ 58%]
tests/test_socketblocker.py::test_localconnect_succeeds[localhost] PASSED [ 66%]
tests/test_socketblocker.py::test_localconnect_succeeds[127.0.0.1] PASSED [ 75%]
tests/test_socketblocker.py::test_multiprocessing_forkserver PASSED      [ 83%]
tests/test_strict_check.py::test_local_config PASSED                     [ 91%]
tests/test_strict_check.py::test_strict_behavior PASSED                  [100%]

=============================== warnings summary ===============================
tests/test_socketblocker.py::test_localconnect_succeeds[localhost]
tests/test_socketblocker.py::test_localconnect_succeeds[127.0.0.1]
  /tmp/guix-build-python-pytest-remotedata-0.4.0.drv-0/pytest-remotedata-0.4.0/tests/test_socketblocker.py:48: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead
    server.setDaemon(True)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============ 9 passed, 3 skipped, 3 deselected, 2 warnings in 3.92s ============

Thanks

bsipocz commented 1 year ago

Thank you, this is a huge oversight in the test suite that we don't error out on Warnings (and thus not picking up these).