search

astropy / pytest-remotedata

Pytest plugin to control whether tests are run that have remote data
BSD 3-Clause "New" or "Revised" License
23 stars 15 forks source link

Replace deprecated code #69

Closed eerovaher closed 1 year ago

eerovaher commented 1 year ago

The first commit replaces a method call that is deprecated since Python 3.10 and fixes #68. The second commit configures pytest to convert uncaught warnings to errors, which would have revealed the deprecation earlier.

pllim commented 1 year ago

There is ResourceWarning: unclosed <socket.socket in a few jobsbut I don't see them inmain` (e.g., https://github.com/astropy/pytest-remotedata/actions/runs/4776300946/jobs/8491233375). Do you have to now close the socket manually or something?

eerovaher commented 1 year ago

I needed to add a third commit with cleanup code to make all the tests pass.